Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump actions' versions for muting warning from GitHub workflow #5340

Merged
merged 1 commit into from
Feb 6, 2024
Merged

Bump actions' versions for muting warning from GitHub workflow #5340

merged 1 commit into from
Feb 6, 2024

Conversation

JohnNiang
Copy link
Member

What type of PR is this?

/kind cleanup
/area core
/milestone 2.13.x

What this PR does / why we need it:

Recently, I noticed that there are a few warnings from GitHub actions, please see the annotations below:

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-node@v3, pnpm/action-setup@v2, actions/cache@v3, codecov/codecov-action@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

According to the instruction, I bump actions' verisons which have adapted to node 20.

However, only pnpm/action-setup hasn't adapted to node 20 yet, see pnpm/action-setup#99 for more.

Does this PR introduce a user-facing change?

None

@f2c-ci-robot f2c-ci-robot bot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Feb 6, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.13.x milestone Feb 6, 2024
@f2c-ci-robot f2c-ci-robot bot added the area/core Issues or PRs related to the Halo Core label Feb 6, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from guqing and wan92hen February 6, 2024 07:42
@JohnNiang JohnNiang force-pushed the chore/remove-warning-from-actions branch from 1107ba4 to 77a34c1 Compare February 6, 2024 07:57
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 6, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.3% Duplication on New Code

See analysis details on SonarCloud

@codecov Codecov
Copy link

codecov bot commented Feb 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2cf19a4) 56.91% compared to head (77a34c1) 56.91%.

Additional details and impacted files 
@@            Coverage Diff            @@
##               main    #5340   +/-   ##
=========================================
  Coverage     56.91%   56.91%           
  Complexity     3319     3319           
=========================================
  Files           587      587           
  Lines         18968    18968           
  Branches       1401     1401           
=========================================
  Hits          10795    10795           
  Misses         7594     7594           
  Partials        579      579

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ruibaby
ruibaby approved these changes Feb 6, 2024
View reviewed changes
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Feb 6, 2024
@f2c-ci-robot f2c-ci-robot
Copy link

f2c-ci-robot bot commented Feb 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 6, 2024
@JohnNiang JohnNiang merged commit fe3df4b into halo-dev:main Feb 6, 2024
8 checks passed
@JohnNiang JohnNiang deleted the chore/remove-warning-from-actions branch February 6, 2024 15:03
@JohnNiang
Copy link
Member Author

The pnpm/action-setup#99 (comment) has been resolved. I'm going to submit another PR to upgrade the action.

@JohnNiang JohnNiang mentioned this pull request Feb 18, 2024
Merged
f2c-ci-robot bot pushed a commit that referenced this pull request Feb 18, 2024
@JohnNiang
Bump pnpm/action-setup version to 3.0.0 (#5364)
94a51ab 
#### What type of PR is this?

/kind cleanup
/area core

#### What this PR does / why we need it:

See #5340 (comment) for more.

#### Does this PR introduce a user-facing change?

```release-note
None
```
@ruibaby ruibaby modified the milestones: 2.13.x, 2.13.0 Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruibaby ruibaby ruibaby approved these changes

@guqing guqing Awaiting requested review from guqing

@wan92hen wan92hen Awaiting requested review from wan92hen

Assignees

@ruibaby ruibaby

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Milestone
2.13.0
Development

Successfully merging this pull request may close these issues.
2 participants
@JohnNiang @ruibaby